0003968: Inner classes should be made static for efficiency and to reduce coupling - SymmetricDS

ID	Project	Category	View Status	Date Submitted	Last Update

0003968	SymmetricDS	Improvement	public	2019-05-16 15:58	2019-05-20 14:00

Reporter	~~user606~~	Assigned To	~~user606~~
Priority	normal
Status	resolved	Resolution	fixed
Product Version	3.9.21
Target Version	3.10.3	Fixed in Version	3.10.3

Summary	0003968: Inner classes should be made static for efficiency and to reduce coupling
Description	Discussion here: https://github.com/JumpMind/symmetric-ds/pull/98
Tags	No tags attached.

SymmetricDS: 3.9 ddac0b8d 2019-05-16 11:59:33 DAVECRAMER Committer: jfrees Details Diff	0003968: Inner classes should be made static for efficiency and to reduce coupling (#98) * make all inner classes static * more static inner classes	Affected Issues 0003968
	mod - symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidSymmetricEngine.java	Diff File
	mod - symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractTriggerTemplate.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/DbCompare.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/stage/SimpleStagingDataWriter.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ConfigurationService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataExtractorService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ExtensionService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/FileSyncService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/IncomingBatchService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/MonitorService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeCommunicationService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OfflinePullService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OutgoingBatchService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/SequenceService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TriggerRouterService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/ConcurrentConnectionManager.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/file/FileIncomingTransport.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/http/HttpBandwidthUrlSelector.java	Diff File
	mod - symmetric-core/src/test/java/org/jumpmind/symmetric/route/DataGapRouteReaderTest.java	Diff File
	mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractDataExtractorServiceTest.java	Diff File
	mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvReader.java	Diff File
	mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvWriter.java	Diff File
	mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java	Diff File
	mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java	Diff File
	mod - symmetric-io/src/test/java/org/jumpmind/symmetric/io/AbstractWriterTest.java	Diff File
	mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherDataRouterTest.java	Diff File
	mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherFilterTest.java	Diff File
	mod - symmetric-sqlexplorer/src/main/java/org/jumpmind/vaadin/ui/sqlexplorer/QueryPanel.java	Diff File
	rm - symmetric-sqlexplorer/src/main/webapp/VAADIN/themes/sqlexplorer/addons.scss	Diff File
	mod - symmetric-util/src/main/java/org/jumpmind/util/SimpleClassCompiler.java	Diff File
	mod - symmetric-util/src/test/java/org/jumpmind/util/SymRollingFileAppenderTest.java	Diff File
	mod - symmetric-wrapper/src/main/java/org/jumpmind/symmetric/wrapper/WrapperConfig.java	Diff File
SymmetricDS: 3.10 956ef137 2019-05-16 11:59:33 DAVECRAMER Committer: jfrees Details Diff	0003968: Inner classes should be made static for efficiency and to reduce coupling (#98) * make all inner classes static * more static inner classes (cherry picked from commit ddac0b8d69cb12ffaa6306b04203e56a9bacf240)	Affected Issues 0003968
	mod - symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidSymmetricEngine.java	Diff File
	mod - symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractTriggerTemplate.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/DbCompare.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/stage/SimpleStagingDataWriter.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ConfigurationService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataExtractorService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ExtensionService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/FileSyncService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/IncomingBatchService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/MonitorService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeCommunicationService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OfflinePullService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OutgoingBatchService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/SequenceService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TriggerRouterService.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/ConcurrentConnectionManager.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/file/FileIncomingTransport.java	Diff File
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/http/HttpBandwidthUrlSelector.java	Diff File
	mod - symmetric-core/src/test/java/org/jumpmind/symmetric/route/DataGapRouteReaderTest.java	Diff File
	mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractDataExtractorServiceTest.java	Diff File
	mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvReader.java	Diff File
	mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvWriter.java	Diff File
	mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java	Diff File
	mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java	Diff File
	mod - symmetric-io/src/test/java/org/jumpmind/symmetric/io/AbstractWriterTest.java	Diff File
	mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherDataRouterTest.java	Diff File
	mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherFilterTest.java	Diff File
	mod - symmetric-sqlexplorer/src/main/java/org/jumpmind/vaadin/ui/sqlexplorer/QueryPanel.java	Diff File
	rm - symmetric-sqlexplorer/src/main/webapp/VAADIN/themes/sqlexplorer/addons.scss	Diff File
	mod - symmetric-util/src/main/java/org/jumpmind/util/SimpleClassCompiler.java	Diff File
	mod - symmetric-util/src/test/java/org/jumpmind/util/SymRollingFileAppenderTest.java	Diff File
	mod - symmetric-wrapper/src/main/java/org/jumpmind/symmetric/wrapper/WrapperConfig.java	Diff File
SymmetricDS: 3.10 68d5dfa5 2019-05-16 16:55:15 jfrees Details Diff	0003968: Fix visibility issue	Affected Issues 0003968
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java	Diff File
SymmetricDS: 3.9 150eaca9 2019-05-20 09:06:00 jfrees Details Diff	0003968: Fix visibility issue	Affected Issues 0003968
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java	Diff File

Date Modified	Username	Field	Change
2019-05-16 15:58	~~user606~~	New Issue
2019-05-16 15:58	~~user606~~	Status	new => assigned
2019-05-16 15:58	~~user606~~	Assigned To	=> user606
2019-05-16 16:00	jfrees	Changeset attached	=> SymmetricDS 3.9 ddac0b8d
2019-05-16 17:00	jfrees	Changeset attached	=> SymmetricDS 3.10 956ef137
2019-05-16 18:17	~~user606~~	Status	assigned => resolved
2019-05-16 18:17	~~user606~~	Resolution	open => fixed
2019-05-16 21:00	jfrees	Changeset attached	=> SymmetricDS 3.10 68d5dfa5
2019-05-20 14:00	jfrees	Changeset attached	=> SymmetricDS 3.9 150eaca9

View Issue Details

Activities

Related Changesets

Issue History