View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004309 | SymmetricDS | Bug | public | 2020-03-11 17:41 | 2020-03-17 18:43 |
| Reporter | elong | Assigned To | elong | ||
| Priority | normal | ||||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.9.18 | ||||
| Target Version | 3.11.7 | Fixed in Version | 3.11.7 | ||
| Summary | 0004309: batchError incorrectly checks create time | ||||
| Description | In the MonitorTypeBatchError.check(monitor) method we add count of error batches to the result object basing on the error batch create time: ------------------------------------------------------------------------------------------------------------------------- int batchErrorMinutes = (int) (System.currentTimeMillis() - batch.getCreateTime().getTime()) / 60000; if (batchErrorMinutes >= monitor.getThreshold()) { ..... outgoingErrorCount++; ..... } event.setValue(outgoingErrorCount + incomingErrorCount); ------------------------------------------------------------------------------------------------------------------------- but after that in MonitorService.updateMonitor(........) we add to the sym_monitor_event the which value is more than monitor. The value here is the count of error batches. ------------------------------------------------------------------------------------------------------------------------- } else if (eventValue.getValue() >= monitor.getThreshold()) { ..... ...... ..... } ------------------------------------------------------------------------------------------------------------------------- Is it expected behavior that first we compare time in minutes with threshold and after that, we compare count of events with threshold? | ||||
| Steps To Reproduce | No need, see code. MonitorService and MonitorTypeBatchError classes | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-03-11 17:41 | elong | New Issue | |
| 2020-03-11 17:41 | elong | Status | new => assigned |
| 2020-03-11 17:41 | elong | Assigned To | => elong |
| 2020-03-11 17:41 | elong | Issue generated from: 0004286 | |
| 2020-03-11 17:41 | elong | Relationship added | related to 0004286 |
| 2020-03-11 17:41 | elong | Status | assigned => resolved |
| 2020-03-11 17:41 | elong | Resolution | open => fixed |
| 2020-03-11 17:41 | elong | Fixed in Version | => 3.11.7 |
| 2020-03-17 18:43 | admin | Status | resolved => closed |