View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004286 | SymmetricDS | Bug | public | 2020-02-24 14:03 | 2020-03-17 18:42 |
Reporter | pyotrk | Assigned To | elong | ||
Priority | normal | ||||
Status | closed | Resolution | fixed | ||
Product Version | 3.9.18 | ||||
Target Version | 3.10.11 | Fixed in Version | 3.10.11 | ||
Summary | 0004286: batchError monitor threshold logic | ||||
Description | In the MonitorTypeBatchError.check(monitor) method we add count of error batches to the result object basing on the error batch create time: ------------------------------------------------------------------------------------------------------------------------- int batchErrorMinutes = (int) (System.currentTimeMillis() - batch.getCreateTime().getTime()) / 60000; if (batchErrorMinutes >= monitor.getThreshold()) { ..... outgoingErrorCount++; ..... } event.setValue(outgoingErrorCount + incomingErrorCount); ------------------------------------------------------------------------------------------------------------------------- but after that in MonitorService.updateMonitor(........) we add to the sym_monitor_event the which value is more than monitor. The value here is the count of error batches. ------------------------------------------------------------------------------------------------------------------------- } else if (eventValue.getValue() >= monitor.getThreshold()) { ..... ...... ..... } ------------------------------------------------------------------------------------------------------------------------- Is it expected behavior that first we compare time in minutes with threshold and after that, we compare count of events with threshold? | ||||
Steps To Reproduce | No need, see code. MonitorService and MonitorTypeBatchError classes | ||||
Tags | No tags attached. | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2020-02-24 14:03 | pyotrk | New Issue | |
2020-03-11 17:36 | elong | Assigned To | => elong |
2020-03-11 17:36 | elong | Status | new => assigned |
2020-03-11 17:36 | elong | Target Version | => 3.10.11 |
2020-03-11 17:36 | elong | Note Added: 0001690 | |
2020-03-11 17:37 | elong | Status | assigned => resolved |
2020-03-11 17:37 | elong | Resolution | open => fixed |
2020-03-11 17:37 | elong | Fixed in Version | => 3.10.11 |
2020-03-11 17:41 | elong | Issue cloned: 0004309 | |
2020-03-11 17:41 | elong | Relationship added | related to 0004309 |
2020-03-11 18:00 | admin | Changeset attached | => SymmetricDS 3.10 7fd26dde |
2020-03-17 18:42 | admin | Status | resolved => closed |