View Issue Details

IDProjectCategoryView StatusLast Update
0004614SymmetricDSImprovementpublic2020-11-09 15:15
Reporterpmarzullo Assigned Topmarzullo  
Prioritynormal 
Status closedResolutionfixed 
Product Version3.12.4 
Target Version3.12.5Fixed in Version3.12.5 
Summary0004614: SQL Server trigger creation should use CREATE OR ALTER TRIGGER syntax to eliminate the loss of data capture
DescriptionWhen SQL Server rebuilds triggers, it first must drop the existing trigger, then create the new trigger, causing the loss of captured data changes if the data on the table changes after the trigger has been dropped but before the new trigger has been created.

We should use CREATE OR ALTER TRIGGER to eliminate that chance of lost data capture.

This only applies to SQL Server 2016 and later.
Tagsdialect: sql-server, trigger

Activities

There are no notes attached to this issue.

Related Changesets

SymmetricDS: 3.12 50c9aa68

2020-10-30 21:02:29

pmarzullo

Details Diff
0004614: SQL Server trigger creation should use CREATE OR ALTER TRIGGER
syntax to eliminate the loss of data capture
Affected Issues
0004614
mod - symmetric-client/src/integrationTest/java/org/jumpmind/symmetric/io/data/writer/AbstractBulkDatabaseWriterTest.java Diff File
mod - symmetric-client/src/integrationTest/java/org/jumpmind/symmetric/io/data/writer/MsSqlBulkDatabaseWriterTest.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/db/JdbcSymmetricDialectFactory.java Diff File
add - symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSql2016SymmetricDialect.java Diff File
add - symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSql2016TriggerTemplate.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSqlTriggerTemplate.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/ext/BulkDataLoaderFactory.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/ext/MsSqlBulkDataLoaderFactory.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractTriggerTemplate.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataExtractorService.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractDataLoaderServiceTest.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractRouterServiceTest.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/platform/DatabaseNamesConstants.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/platform/DdlBuilderFactory.java Diff File
add - symmetric-db/src/main/java/org/jumpmind/db/platform/mssql/MsSql2016DdlBuilder.java Diff File
mod - symmetric-io/src/integrationTest/java/org/jumpmind/symmetric/io/data/writer/DatabaseWriterTest.java Diff File
mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbExport.java Diff File
mod - symmetric-jdbc/src/integrationTest/java/org/jumpmind/db/DatabasePlatformTest.java Diff File
add - symmetric-jdbc/src/integrationTest/java/org/jumpmind/db/platform/mssql/MSSql2016DdlTypesTest.java Diff File
mod - symmetric-jdbc/src/main/java/org/jumpmind/db/platform/JdbcDatabasePlatformFactory.java Diff File
add - symmetric-jdbc/src/main/java/org/jumpmind/db/platform/mssql/MsSql2016DatabasePlatform.java Diff File

Issue History

Date Modified Username Field Change
2020-10-30 17:26 pmarzullo New Issue
2020-10-30 17:26 pmarzullo Status new => assigned
2020-10-30 17:26 pmarzullo Assigned To => pmarzullo
2020-10-30 17:26 pmarzullo Tag Attached: dialect: sql-server
2020-10-30 17:26 pmarzullo Tag Attached: trigger
2020-10-30 17:28 pmarzullo Description Updated View Revisions
2020-10-30 22:00 pmarzullo Changeset attached => SymmetricDS 3.12 50c9aa68
2020-11-04 20:28 pmarzullo Status assigned => resolved
2020-11-04 20:28 pmarzullo Resolution open => fixed
2020-11-04 20:28 pmarzullo Fixed in Version => 3.12.5
2020-11-09 15:15 admin Status resolved => closed