0005909: Some methods are synchronized unnecessarily in AbstractParameterService - SymmetricDS

ID	Project	Category	View Status	Date Submitted	Last Update

0005909	SymmetricDS	Improvement	public	2023-07-03 14:36	2023-07-03 15:00

Reporter	cquamme	Assigned To	cquamme
Priority	normal
Status	closed	Resolution	fixed
Target Version	3.14.8	Fixed in Version	3.14.8

Summary	0005909: Some methods are synchronized unnecessarily in AbstractParameterService
Description	We should remove the "synchronized" keyword for getNodeGroupOd(), getExternalId(), getEngineName(), getSyncUrl(), and getRegistrationUrl() in AbstractParameterService. In the AbstractSymmetricEngine.init(), it already calls those methods from the single startup thread to make sure they are initialized, so it is unnecessary to have them be synchronized methods.
Tags	No tags attached.

SymmetricDS: 3.14 94e7861a 2023-07-03 14:38:43 cquamme Details Diff	0005909: Some methods are synchronized unnecessarily in AbstractParameterService		Affected Issues 0005909
	mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/AbstractParameterService.java		Diff File

Date Modified	Username	Field	Change
2023-07-03 14:36	cquamme	New Issue
2023-07-03 14:36	cquamme	Status	new => assigned
2023-07-03 14:36	cquamme	Assigned To	=> cquamme
2023-07-03 14:50	elong	Note Added: 0002350
2023-07-03 14:55	cquamme	Status	assigned => resolved
2023-07-03 14:55	cquamme	Resolution	open => fixed
2023-07-03 15:00	cquamme	Changeset attached	=> SymmetricDS 3.14 94e7861a
2023-07-19 12:58	admin	Status	resolved => closed

elong 2023-07-03 14:50 developer ~0002350	Introduced by 0003959 in 3.9.21 and 3.10.3. Since then, we saw an issue where one thread is stuck in rereadDatabaseParameters() waiting for database/network and all other threads block on getEngineName() trying to handle incoming Jetty requests.