View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006232 | SymmetricDS Pro | Bug | public | 2024-02-08 15:50 | 2024-03-18 15:15 |
Reporter | elong | Assigned To | cquamme | ||
Priority | normal | ||||
Status | closed | Resolution | fixed | ||
Product Version | 3.15.0 | ||||
Target Version | 3.15.4 | Fixed in Version | 3.15.4 | ||
Summary | 0006232: Node group summary database icons sometimes broken | ||||
Description | Sometimes the database icon is broken on the Dashboard's Node Group Summary panel. H2 database is an example. It is looking for /icons/databases/H2-48x48.png instead of /icons/databases/h2-48x48.png (the database name should be lower case). There is a method in DesignUtils called getMappedDatabaseType() that is converting the sym_node.database_type to one that matches the icon file name. It would be good to understand and straighten out confusion about: - DatabaseNamesConstants - sym_node.database_type - sym_node.database_name | ||||
Tags | No tags attached. | ||||
|
|
|
The capitalized "H2" is coming from the Node's databaseType of "H2". Because there is no check for H2 in getMappedDatabaseType(), it returns the type "H2". We can either add a check to see if the type.toLowerCase().equals(DatabaseNamesConstants.H2), and if so return DatabaseNamesConstants.H2, or we can change the database Type information for H2. This is currently set in the SetupDatabaseScreen. Every database has a capitalized type name. Database name in the node comes from engine.getDatabasePlatform().getName(), which is set by the DatabaseNamesConstants. It might be good to use the DatabaseNamesConstants in place of the string literals in SetupDatabaseScreen. That way they're defined one place and everything should be consistent. |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-02-08 15:50 | elong | New Issue | |
2024-02-08 15:50 | elong | Status | new => assigned |
2024-02-08 15:50 | elong | Assigned To | => cquamme |
2024-02-08 15:50 | elong | File Added: node-group-summary.png | |
2024-02-08 15:51 | elong | Description Updated | View Revisions |
2024-02-12 18:35 | cquamme | Note Added: 0002410 | |
2024-02-12 18:40 | cquamme | Note Edited: 0002410 | View Revisions |
2024-02-12 18:45 | cquamme | Note Edited: 0002410 | View Revisions |
2024-03-18 15:15 | cquamme | Status | assigned => resolved |
2024-03-18 15:15 | cquamme | Resolution | open => fixed |
2024-03-18 15:15 | cquamme | Fixed in Version | => 3.15.4 |
2024-03-19 16:20 | admin | Status | resolved => closed |