View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006676 | SymmetricDS | Improvement | public | 2024-12-12 15:07 | 2024-12-19 16:08 |
| Reporter | cquamme | Assigned To | cquamme | ||
| Priority | normal | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.15.0 | ||||
| Target Version | 3.15.12 | Fixed in Version | 3.15.12 | ||
| Summary | 0006676: Preserve comments on stored procedures when loading DDL changes (new parameter dataloader.sql.event.strip.comments) | ||||
| Description | When you sync a stored procedure with comments that contains comments, the comments do not get synced. We would like to change this so comments get synced as well, when a new parameter dataloader.sql.event.strip.comments is set to false To maintain backwards compatibility this parameter will default to true. | ||||
| Steps To Reproduce | -- Procedure - for MS SQL Server syntax: CREATE OR ALTER PROCEDURE dbo.test_comments @Rounds INT AS BEGIN -- This rocedure fills existing table random_load_test2 with random values DECLARE @completedRounds INT = 0 /* * DONE! * populate_random_load_test2 555 */ SET @completedRounds = @completedRounds + 1 END; | ||||
| Tags | data sync, dialect: sql-server | ||||
|
|
PR here: https://github.com/JumpMind/symmetric-ds/pull/213 |
|
|
Merged PR https://github.com/JumpMind/symmetric-ds/pull/213 into 3.15 |
|
SymmetricDS: 3.15 ef157e88 2024-12-19 13:55:41 catherinequamme Committer: GitHub Details Diff |
0006676: Comments on stored procedures do not get migrated with DDL (0000213) 0006676: Comments on stored procedures do not get migrated with DDL. New parameter dataloader.sql.event.strip.comments |
Affected Issues 0006676 |
|
| mod - symmetric-core/src/main/java/org/jumpmind/symmetric/common/ParameterConstants.java | Diff File | ||
| mod - symmetric-core/src/main/java/org/jumpmind/symmetric/load/AbstractDataLoaderFactory.java | Diff File | ||
| mod - symmetric-core/src/main/resources/symmetric-default.properties | Diff File | ||
| mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java | Diff File | ||
| mod - symmetric-db/src/test/java/org/jumpmind/db/sql/SqlScriptReaderTest.java | Diff File | ||
| mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DatabaseWriterSettings.java | Diff File | ||
| mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DefaultDatabaseWriter.java | Diff File | ||
| mod - symmetric-sqlexplorer/src/main/java/org/jumpmind/vaadin/ui/sqlexplorer/SqlRunner.java | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-12-12 15:07 | cquamme | New Issue | |
| 2024-12-12 15:07 | cquamme | Tag Attached: dialect: sql-server | |
| 2024-12-12 15:14 | cquamme | Assigned To | => cquamme |
| 2024-12-12 15:14 | cquamme | Status | new => assigned |
| 2024-12-12 17:27 | pbelov | Additional Information Updated | View Revisions |
| 2024-12-12 19:00 | cquamme | Additional Information Updated | View Revisions |
| 2024-12-13 20:10 | cquamme | Status | assigned => feedback |
| 2024-12-13 20:11 | cquamme | Note Added: 0002563 | |
| 2024-12-19 13:56 | pbelov | Status | feedback => resolved |
| 2024-12-19 13:56 | pbelov | Resolution | open => fixed |
| 2024-12-19 13:56 | pbelov | Note Added: 0002564 | |
| 2024-12-19 13:57 | pbelov | Tag Attached: data sync | |
| 2024-12-19 14:00 | Changeset attached | => SymmetricDS 3.15 ef157e88 | |
| 2024-12-19 16:08 | pbelov | Summary | Comments on stored procedures do not get migrated with DDL enabled in SQL Server => Preserve comments on stored procedures when loading DDL changes (new parameter dataloader.sql.event.strip.comments) |
| 2024-12-19 16:08 | pbelov | Description Updated | View Revisions |
| 2024-12-19 16:08 | pbelov | Steps to Reproduce Updated | View Revisions |