View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006637SymmetricDSImprovementpublic2024-11-06 18:082025-02-14 14:27
Reporterrichard@deepred.co.za Assigned Topbelov  
Prioritynormal 
Status closedResolutionfixed 
Product Version3.15.0 
Target Version3.15.13Fixed in Version3.15.13 
Summary0006637: Add support for Derby boolean data types
DescriptionCurrently, the Derby dialect does not support the boolean data type. It would be good to set the booleanColumnTemplate in DerbyTriggerTemplate to add support for this data type.

[TriggerRouterService] [server-dby1016root-sync-triggers-1] Failed to create triggers for APP.RANDOM_INT_BOOLEAN StackTraceKey.init [NotImplementedException:2372351393]
org.apache.commons.lang3.NotImplementedException: Table Table [name=RANDOM_INT_BOOLEAN; 2 columns] column Column [name=CLBOOLEAN; jdbcType=BOOLEAN; mappedType=BOOLEAN]
    at org.jumpmind.symmetric.db.AbstractTriggerTemplate.fillOutColumnTemplate(AbstractTriggerTemplate.java:990)
    at org.jumpmind.symmetric.db.AbstractTriggerTemplate.buildColumnsString(AbstractTriggerTemplate.java:830)
    at org.jumpmind.symmetric.db.AbstractTriggerTemplate.replaceTemplateVariables(AbstractTriggerTemplate.java:516)
    at org.jumpmind.symmetric.db.AbstractTriggerTemplate.createTriggerDDL(AbstractTriggerTemplate.java:385)
    at org.jumpmind.symmetric.db.AbstractSymmetricDialect.createTrigger(AbstractSymmetricDialect.java:410)
    at org.jumpmind.symmetric.service.impl.TriggerRouterService.rebuildTriggerIfNecessaryWithException(TriggerRouterService.java:2528)
    at org.jumpmind.symmetric.service.impl.TriggerRouterService.rebuildTriggerIfNecessary(TriggerRouterService.java:2404)
    at org.jumpmind.symmetric.service.impl.TriggerRouterService.updateOrCreateDatabaseTriggers(TriggerRouterService.java:2355)
    at org.jumpmind.symmetric.service.impl.TriggerRouterService.updateOrCreateDatabaseTrigger(TriggerRouterService.java:2198)
    at org.jumpmind.symmetric.service.impl.TriggerRouterService$2.run(TriggerRouterService.java:2052)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:840)
Steps To Reproduce-- Derby (Apache DB)
CREATE TABLE APP.RANDOM_INT_BOOLEAN(
    clint INT NOT NULL,
    clboolean BOOLEAN ,
    PRIMARY KEY (clint)
);


INSERT INTO APP.RANDOM_INT_BOOLEAN2 VALUES(1,NULL, 'test1');
INSERT INTO APP.RANDOM_INT_BOOLEAN2 VALUES(2,FALSE, 'test2');
INSERT INTO APP.RANDOM_INT_BOOLEAN2 VALUES(3,TRUE, 'test3');

select * from APP.RANDOM_INT_BOOLEAN;

select * from sym_trigger where source_table_name = 'RANDOM_INT_BOOLEAN';

select * from sym_data where table_name = 'RANDOM_INT_BOOLEAN';
Additional Informationhttps://sourceforge.net/p/symmetricds/discussion/739236/thread/f6b954c4/?limit=25#7e58
Tagsdata type, dialect: Derby (Apache DB)

Relationships

has duplicate 0006700 closedpbelov boolean constants in csv row data are not converted correctly on Postgres 

Activities

pbelov

2025-02-08 02:07

manager   ~0002607

Last edited: 2025-02-08 16:05

View 4 revisions

 @RomeoPapaFoxtrot, to allow local testing I had migrated your PR here and added a unit test.
Testing was successful.
Created PR for team review https://github.com/JumpMind/symmetric-ds/pull/225

richard@deepred.co.za

2025-02-09 15:01

reporter   ~0002608

@pbelov, I checked the PR and it looks good. thanks.

pbelov

2025-02-10 13:57

manager   ~0002609

Merged pull request: https://github.com/JumpMind/symmetric-ds/pull/225

pbelov

2025-02-14 14:27

manager   ~0002630

Released as part of 3.15.13

Related Changesets

SymmetricDS: 3.15 a5ca5d78

2025-02-10 13:56:03

pbelov


Committer: GitHub Details Diff 		0006637 Added support for the BOOLEAN column data type in Derby (Apache DB) (0000225)

* Added support for the BOOLEAN column data type in Derby (Apache DB) as
proposed by Richard and Eric
* Added unit test testParseBoolean
* Adjust message of NotImplementedException to remove duplication of words Table and Column		 Affected Issues
0006637
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/db/derby/DerbyTriggerTemplate.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractTriggerTemplate.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java Diff File
mod - symmetric-db/src/test/java/org/jumpmind/db/platform/AbstractDatabasePlatformTest.java Diff File

Issue History

Date Modified Username Field Change
2024-11-06 18:08 emiller New Issue
2024-11-06 18:08 emiller Tag Attached: data type
2024-11-06 18:08 emiller Tag Attached: dialect: derby
2024-12-03 19:14 pbelov Target Version 3.15.11 => 3.15.12
2025-01-03 14:07 pbelov Target Version 3.15.12 => 3.15.13
2025-01-29 18:45 emiller Relationship added has duplicate 0006700
2025-01-29 20:16 admin Tag Renamed dialect: derby => dialect: Derby (Apache DB)
2025-02-08 02:07 pbelov Note Added: 0002607
2025-02-08 16:02 pbelov Note Edited: 0002607 View Revisions
2025-02-08 16:03 pbelov Note Edited: 0002607 View Revisions
2025-02-08 16:03 pbelov Note View State: 0002607: public
2025-02-08 16:05 pbelov Note Edited: 0002607 View Revisions
2025-02-08 16:20 pbelov Reporter emiller => richard@deepred.co.za
2025-02-08 16:20 pbelov Assigned To => pbelov
2025-02-08 16:20 pbelov Status new => confirmed
2025-02-08 16:20 pbelov Description Updated View Revisions
2025-02-08 16:20 pbelov Steps to Reproduce Updated View Revisions
2025-02-09 15:01 richard@deepred.co.za Note Added: 0002608
2025-02-10 13:57 pbelov Status confirmed => resolved
2025-02-10 13:57 pbelov Resolution open => fixed
2025-02-10 13:57 pbelov Fixed in Version => 3.15.13
2025-02-10 13:57 pbelov Note Added: 0002609
2025-02-10 14:00 pbelov Changeset attached => SymmetricDS 3.15 a5ca5d78
2025-02-10 21:27 pbelov Steps to Reproduce Updated View Revisions
2025-02-14 14:27 pbelov Note Added: 0002630
2025-02-14 14:27 pbelov Status resolved => closed